Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frame names in the allocation table for simple GT job #8731

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Fix frame names in the allocation table for simple GT job #8731

merged 3 commits into from
Dec 3, 2024

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Nov 21, 2024 •
edited by coderabbitai bot
Loading

Motivation and context

  • Fixed invalid display of frame names in quality management for tasks with a simple GT job

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Enhanced the AllocationTable component to display frame names based on the selected validation mode.

  • Bug Fixes

    • Improved accuracy of frame name retrieval in the allocation table, ensuring correct display under different validation conditions.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2024 •
edited
Loading

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes involve modifications to the AllocationTable component within allocation-table.tsx. A new import for ValidationMode has been added, and the logic for determining the name property in the data array has been updated. The name is now conditionally set based on the value of validationLayout.mode, specifically checking if it equals ValidationMode.GT. This adjustment affects how frame names are retrieved without altering the overall structure or interface of the component.

Changes

File Path Change Summary
cvat-ui/src/components/quality-control/task-quality/allocation-table.tsx Added import for ValidationMode. Updated logic for name property in data array based on validationLayout.mode.

Poem

In the land of code where rabbits play,
A new mode of validation came to stay.
With frames aligned and names just right,
Our AllocationTable shines so bright!
Hops of joy in every line,
For changes made, oh how divine! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zhiltsov-max zhiltsov-max changed the title Add simple fix for the allocation table frame names Fix frame names in the allocation table for simple GT job Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (3eec9fe) to head (f732769).
Report is 17 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8731      +/-   ##
===========================================
- Coverage    74.18%   73.91%   -0.27%     
===========================================
  Files          401      409       +8     
  Lines        43510    43932     +422     
  Branches      3950     3984      +34     
===========================================
+ Hits         32278    32474     +196     
- Misses       11232    11458     +226
Components Coverage Δ
cvat-ui 78.34% <ø> (-0.16%) ⬇️
cvat-server 70.12% <ø> (-0.37%) ⬇️

@klakhov klakhov added the ui/ux label Nov 28, 2024
@zhiltsov-max zhiltsov-max merged commit 17ec908 into develop Dec 3, 2024
33 checks passed
@zhiltsov-max zhiltsov-max deleted the zm/fix-allocation-table branch December 3, 2024 09:01
@cvat-bot cvat-bot bot mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov approved these changes

@bsekachev bsekachev Awaiting requested review from bsekachev bsekachev is a code owner

@nmanovic nmanovic Awaiting requested review from nmanovic nmanovic is a code owner

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiltsov-max @codecov-commenter @klakhov